Skip to content

fix: Set join rules with knowk_restricted and multiple allow condition room ids #2169

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 30, 2025
Merged

fix: Set join rules with knowk_restricted and multiple allow condition room ids #2169

merged 1 commit into from
Oct 30, 2025
+17 −5

Conversation

@krille-chan
Copy link
Contributor

No description provided.

@codecov
Copy link

codecov bot commented Oct 19, 2025 •
edited
Loading

Codecov Report

❌ Patch coverage is 12.50000% with 7 lines in your changes missing coverage. Please review.
✅ Project coverage is 56.95%. Comparing base (c3f89d9) to head (eb2cd6c).
⚠️ Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
lib/src/room.dart 12.50% 7 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #2169      +/-   ##
==========================================
- Coverage   56.96%   56.95%   -0.02%     
==========================================
  Files         148      148              
  Lines       19143    19148       +5     
==========================================
  Hits        10905    10905              
- Misses       8238     8243       +5
Files with missing lines Coverage Δ
lib/src/room.dart 75.59% <12.50%> (-0.37%) ⬇️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c3f89d9...eb2cd6c. Read the comment docs.

@krille-chan krille-chan force-pushed the krille/fix-set-join-rule branch from c8cc53e to 2e0c510 Compare October 27, 2025 09:21
coder-with-a-bushido
coder-with-a-bushido reviewed Oct 27, 2025
View reviewed changes
coder-with-a-bushido
coder-with-a-bushido approved these changes Oct 27, 2025
View reviewed changes
Copy link
Contributor

@coder-with-a-bushido coder-with-a-bushido left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM other than that comment :)

@krille-chan krille-chan force-pushed the krille/fix-set-join-rule branch from 2e0c510 to eb2cd6c Compare October 30, 2025 07:30
@krille-chan krille-chan enabled auto-merge October 30, 2025 07:30
@krille-chan krille-chan merged commit 96f1f05 into main Oct 30, 2025
12 checks passed
@krille-chan krille-chan deleted the krille/fix-set-join-rule branch October 30, 2025 07:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@coder-with-a-bushido coder-with-a-bushido coder-with-a-bushido approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@krille-chan @coder-with-a-bushido